Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use is_terminal in atty #21010

Merged
merged 1 commit into from
Oct 29, 2023
Merged

chore: use is_terminal in atty #21010

merged 1 commit into from
Oct 29, 2023

Conversation

littledivy
Copy link
Member

No description provided.

mmastrac
mmastrac approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice cleanup

@littledivy littledivy merged commit f3b580d into denoland:main Oct 29, 2023
13 checks passed
@littledivy littledivy deleted the isatty_use_isterminal branch October 29, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @mmastrac